Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent user confirmation prompts #4104

Closed
389-ds-bot opened this issue Sep 13, 2020 · 7 comments
Closed

Inconsistent user confirmation prompts #4104

389-ds-bot opened this issue Sep 13, 2020 · 7 comments
Labels
CLI CLI tools closed: fixed Migration flag - Issue
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/51051


Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 8): Bug 1654671

Description of problem:

dsconf Instance sasl delete "SASL mapping name"  asking for confirmation: Type
'Yes I am sure' to continue:

1. [root@server-rhel8 ds]# dsconf localhost sasl list
anuj
Kerberos uid mapping
rfc 2829 dn syntax
rfc 2829 u syntax
uid mapping

2. [root@server-rhel8 ds]# dsconf localhost sasl delete anuj
Deleting SaslMapping cn=anuj,cn=mapping,cn=sasl,cn=config :
Type 'Yes I am sure' to continue: Yes I am sure
Successfully deleted cn=anuj,cn=mapping,cn=sasl,cn=config

Should it be something like "Yes" or "Y" or "y"

----------------------------------------------------

I also want to add the following example:

Removing instances:
[root@server-f29 ds]# dsctl slapd-server-f29 remove 
Not removing: if you are sure, add --do-it
[root@server-f29 ds]# dsctl slapd-server-f29 remove  --do-it 

About to remove instance (server-f29)!
If this is not what you want, press ctrl-c now ...
        
5 ...
4 ...
3 ...
2 ...
1 ...
Removing instance ...
Removed /etc/systemd/system/multi-user.target.wants/dirsrv@server-f29.service.
Completed instance removal

But with --remove-all there is no way to press ctrl-c, it just asks for one "Yes".

[root@server-f29 ds]# dsctl --remove-all
Are you sure you want to remove all the Directory Server instances?  Enter "Yes" to continue: Yes
Removing instance: slapd-localhost
Removed /etc/systemd/system/multi-user.target.wants/dirsrv@localhost.service.
All instances have been successfully removed

I'd argue that --remove-all is more disastrous than deleting just one instance. And we should be using countdown here as well. Or just here, but not when deleting one instance.

@389-ds-bot 389-ds-bot added CLI CLI tools closed: fixed Migration flag - Issue labels Sep 13, 2020
@389-ds-bot 389-ds-bot added this to the 1.4.3 milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-04-27 16:09:05

Metadata Update from @mreynolds389:

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-04-27 18:21:25

Metadata Update from @mreynolds389:

  • Issue assigned to mreynolds389

@389-ds-bot
Copy link
Author

389-ds-bot commented Sep 13, 2020

Comment from mreynolds (@mreynolds389) at 2020-04-27 18:22:53

#4106

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-04-27 18:22:54

Metadata Update from @mreynolds389:

  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-04-27 18:23:24

Metadata Update from @mreynolds389:

  • Issue set to the milestone: 1.4.3 (was: 0.0 NEEDS_TRIAGE)
  • Issue tagged with: CLI

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-05-08 15:56:30

Commit 3def54d relates to this ticket

96184bc..60aa698 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

ae2a2a4..ba3a704 389-ds-base-1.4.2 -> 389-ds-base-1.4.2

f3bd104..f261740 389-ds-base-1.4.1 -> 389-ds-base-1.4.1

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-05-08 15:56:31

Metadata Update from @mreynolds389:

  • Issue close_status updated to: fixed
  • Issue status updated to: Closed (was: Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI CLI tools closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant