Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Issue 50610 - memory leak in dbscan and changelog encryption #4128

Closed
389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Closed

PR - Issue 50610 - memory leak in dbscan and changelog encryption #4128

389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/51075

  • Created at 2020-05-07 15:51:35 by spichugi (@droideck)
  • Merged at 2020-05-12 15:28:43

Bug Description: More leaks are present that involve dbscan
execution (the issue happens on instance restart though).

Fix Description: dbscan - add 'done:' section to which we can
go to if something went worng and free the allocated data.

changelog encryption - add clcrypt_destroy function;
properly free the allocated memory when we go to shutdown.
When we do changelog5_config_done, additionally free
config->symmetricKey, config->dbconfig.encryptionAlgorithm,
and config->dbconfig.symmetricKey

Resolves: #3666

Reviewed by: ?

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2020-05-07 17:15:12

rebased onto 8c27c9027faec6d9b264d3eb6f0efef0c21c588c

@389-ds-bot
Copy link
Author

Comment from lkrispen (@elkris) at 2020-05-12 12:40:06

It is not Initialize

@389-ds-bot
Copy link
Author

Comment from lkrispen (@elkris) at 2020-05-12 12:40:48

looks good

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2020-05-12 15:27:04

rebased onto d45d8bd

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2020-05-12 15:28:43

Pull-Request has been merged by droideck

@389-ds-bot
Copy link
Author

Patch
51075.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant