PR - Issue:51070 - Port Import TET module to python3 part1

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/51081

• Created at 2020-05-11 08:58:52 by aborah (@aborah-sudo)
• Merged at 2020-05-19 11:26:14

---

Bug Description: Port Import TET module to python3 part1

Relates: Resolves: #4123

Author: aborah-sudo

Reviewed by: ???

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-11 23:31:03

First of all, please, write the actual docstring here which describes the area you test. BZ Information is not needed here (pytest.mark is enough)

Second, BZ number leads to a WONTFIX bug about abrt-gui-1.0.9-2.fc12.
It is misleading.

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-11 23:32:53

I think the file needs to be removed after the end of the test suite.

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-11 23:35:39

I think we also need to check the number of users is smaller before the import (it is possible that the number of users before the import == number of users after the import and it still will report a success)

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-11 23:36:43

I think we need to check the import log status that it reports success.

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-11 23:37:08

I think it can be deleted

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-05-13 09:15:03

1 new commit added

• Fixing Simon's comments

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-05-13 09:17:24

I think it can be deleted

Removed

I think we need to check the import log status that it reports success.

Done

I think we also need to check the number of users is smaller before the import (it is possible that the number of users before the import == number of users after the import and it still will report a success)

Done

I think the file needs to be removed after the end of the test suite.

Done

First of all, please, write the actual docstring here which describes the area you test. BZ Information is not needed here (pytest.mark is enough)
Second, BZ number leads to a WONTFIX bug about abrt-gui-1.0.9-2.fc12.
It is misleading.

Removed . May be it was a very old bug that is not even listed in modern BZ

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-14 16:42:41

LGTM
Ack

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-05-18 12:05:46

rebased onto 74abb90b032556a6c1f3cd39398f9516593332e5

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-05-18 12:07:36

rebased onto 5ae11781e0b8c448687694cb991f4373582fe644

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-05-19 11:05:21

rebased onto 75e3b86

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-19 11:26:14

Pull-Request has been merged by droideck

[389-ds-bot]

Patch
51081.patch