PR - Issue 49850 -ldbm_get_nonleaf_ids() painfully slow for databases with many non-leaf entries

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/51099

• Created at 2020-05-19 11:42:44 by sgouvern
• Merged at 2020-05-26 01:10:53

---

Description:
With a very large database, gathering non-leaf IDs for creating the ancestorid index took an enormous amount of time.
This test is to verify the fix for this problem.

Resolves: #2909

Author: sgouvern

Reviewed by: Firstyear, droideck

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2020-05-21 04:11:43

I don't see anything wrong with this test. @vashirov or @droideck ?

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-21 16:21:09

small indentation issue

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-21 16:22:24

I think there is no reason to mention BZ number in the commit message.
It is already mentioned in the pagure issue and as a pytest mark.

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-21 16:22:35

The rest looks good to me.

[389-ds-bot]

Comment from sgouvern at 2020-05-25 10:56:17

rebased onto bed349d7463150ba7febf62365f70cdcfd44e09f

[389-ds-bot]

Comment from sgouvern at 2020-05-25 12:00:28

rebased onto 9d5fe06

[389-ds-bot]

Comment from sgouvern at 2020-05-25 12:09:05

Thanks @Firstyear and @droideck for your review.
I fixed the indentation and commit message issues.
@vashirov, I also changed the pytest marker from skipif to xfail, can you please review ?

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-25 17:11:48

LGTM! Ack

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2020-05-26 01:10:30

@droideck Worth remembering that not everyone has commit rights, so when you ack sometimes you have to do the merge yourself :)

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2020-05-26 01:10:53

Pull-Request has been merged by Firstyear

[389-ds-bot]

Comment from sgouvern at 2020-05-26 09:30:01

Thanks for the go and for the merge :)

[389-ds-bot]

Patch
51099.patch