PR - Issue 51102 - RFE - ds-replcheck - make online timeout configurable

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/51103

• Created at 2020-05-19 21:35:53 by mreynolds (@mreynolds389)
• Merged at 2020-05-20 19:49:48

---

Bug Description:

When doing an online check with replicas that are very far apart the connection can time out as the hardcoded timeout is 5 seconds.

Fix Description:

Change the default timeout to never timeout, and add an CLI option to specify a specific timeout.

Also caught all the possible LDAP exceptions so we can cleanly "fail". Fixed some python syntax issues, and improved the entry inconsistency report

relates: Resolves: #4155

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2020-05-20 02:52:33

Looks reasonable to me. Ack,

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-05-20 19:36:03

We, probably, need to add the argument to state_parser also because get_state also calls init_online_params(args)

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-05-20 19:48:52

rebased onto c350ddc

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-05-20 19:49:24

We, probably, need to add the argument to state_parser also because get_state also calls init_online_params(args)

Nice catch! Done, merging...

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-05-20 19:49:48

Pull-Request has been merged by mreynolds389

[389-ds-bot]

Patch
51103.patch