PR - Issue: 51070 - Port Import TET module to python3 part2

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/51107

• Created at 2020-05-22 13:35:01 by aborah (@aborah-sudo)
• Merged at 2020-06-24 09:54:11

---

Bug Description: Port Import TET module to python3 part2

Fixes: Resolves: #4123

Author: aborah-sudo

Reviewed by: ???

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-05-22 13:39:37

rebased onto ba024953ea16e37c6c5f24784f882d63335da040

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-05-27 07:30:32

rebased onto d2fb1e1162bd79b101140be4005f7f3e2c12f1a7

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-05-28 06:42:51

rebased onto f0e62d6e3ed946bd831dcd2a42b34f917d3be01e

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-01 12:30:37

rebased onto daabe431a8ee7d3b47d8c3011d934ef37d5fc60e

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-22 15:20:32

Instead of silent exception we can use a check if a file exists. And if it is there, then delete it.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-22 15:22:59

For a better readability let's use multiline instead of hardcoding new line symbols.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-22 15:23:40

Please put this on the same line at the start of the docstring

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-22 15:25:38

Perhaps this should be a fixture? If the test fails in the middle, it will leave the instance with this setting on for the following tests.

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-22 16:36:15

rebased onto e44c1d454646743b5cc768e70af7e9dd9dc2daae

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-22 16:37:52

rebased onto b7e76dcf408a821d81d5ac5895cadf77bba173ab

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-22 16:38:14

Instead of silent exception we can use a check if a file exists. And if it is there, then delete it.

Done

For a better readability let's use multiline instead of hardcoding new line symbols.

Done

Please put this on the same line at the start of the docstring

Done

Perhaps this should be a fixture? If the test fails in the middle, it will leave the instance with this setting on for the following tests.

Done

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-22 17:07:18

Instead of silent exception we can use a check if a file exists. And if it is there, then delete it.

Done

I meant something like this:

if os.path.exists(import_ldif):
    os.remove(import_ldif)

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-22 17:09:37

Typo in "bogus" here and below in the file name.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-22 17:14:04

Please use triple quotes for the multiline here.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-22 17:15:16

Please use more descriptive name for this fixture, for example toggle_private_import_mem.

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-23 06:12:52

rebased onto 52879f7342a31cca26c1eed0b81d9972a6daa377

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-23 06:15:26

rebased onto 7cad81162fe9c65a6e9221dc21187be16da4bfdc

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-23 06:19:51

rebased onto 322fb6e551959ffbfcd70bb053c2fb0d95089e35

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-23 06:20:54

Instead of silent exception we can use a check if a file exists. And if it is there, then delete it.

Done

I meant something like this:
if os.path.exists(import_ldif):
os.remove(import_ldif)

Done

Typo in "bogus" here and below in the file name.

Done

Please use triple quotes for the multiline here.

Done

Please use more descriptive name for this fixture, for example toggle_private_import_mem.

Done

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-24 09:49:32

rebased onto bf843907ca33b3bcca517a1d30d74733f1f3b8db

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2020-06-24 09:53:38

rebased onto 0a71c3d

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-06-24 09:54:12

Pull-Request has been merged by vashirov

[389-ds-bot]

Patch
51107.patch