server should not call a plugin after the plugin close function is called

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50

• Created at 2012-01-04 19:24:03 by mkosek
• Closed as Fixed
• Assigned to mreynolds (@mreynolds389)
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=698770

---

https://bugzilla.redhat.com/show_bug.cgi?id=698770

The directory server crashes if it is shutdown before a long running task can
complete

https://bugzilla.redhat.com/show_bug.cgi?id=698421

the reason is that a plugin postop function is being called after the plugin
close function has been called.  Once the server calls the plugin close
function, the plugin should be removed from the list of active plugins, and
plugin_free should be called on that plugin.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2012-01-20 01:00:12

attachment
0001-Ticket-50-server-should-not-call-a-plugin-after-the-.patch

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2012-01-20 01:00:55

Added a new flag to plugin struct to mark when the plugin is closed. This flag is checked when we attempt to call a plugin function. We also now check if the plugin is closed before issuing a plugin task.

Sending fix out for review...

Mark

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2012-01-20 06:04:45

Looks good to me.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2012-01-20 21:31:18

Fix is pushed to master:

[mareynol@mareynol plugins]$ git merge ticket50
Updating 403078e..81737b9
Fast-forward
ldap/servers/plugins/linkedattrs/fixup_task.c | 15 +++++++++++++++
ldap/servers/plugins/linkedattrs/linked_attrs.c | 5 +++++
ldap/servers/plugins/linkedattrs/linked_attrs.h | 5 +++++
ldap/servers/plugins/memberof/memberof.c | 9 +++++++++
ldap/servers/plugins/usn/usn.c | 9 +++++++++
ldap/servers/plugins/usn/usn.h | 1 +
ldap/servers/plugins/usn/usn_cleanup.c | 8 ++++++++
ldap/servers/slapd/plugin.c | 5 ++++-
ldap/servers/slapd/slap.h | 3 ++-
9 files changed, 58 insertions(+), 2 deletions(-)
[mareynol@mareynol plugins]$ git push
Counting objects: 42, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (25/25), done.
Writing objects: 100% (25/25), 2.83 KiB, done.
Total 25 (delta 17), reused 0 (delta 0)
To ssh://mreynolds389@git.fedorahosted.org/git/389/ds.git
403078e..81737b9 master -> master

[389-ds-bot]

Comment from nkinder (@nkinder) at 2012-08-28 04:14:26

Added initial screened field value.

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2017-02-11 23:08:21

Metadata Update from @nhosoi:

• Issue assigned to mreynolds389
• Issue set to the milestone: 1.2.10.a7