remove slapi_attr_init/done in dn normalize code

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/510

• Created at 2012-11-07 03:36:29 by rmeggins (@richm)
• Closed as Fixed
• Assigned to lkrispen (@elkris)

---

systemtap and callgrind analysis show a lot of time spent in this code in both thread contention and malloc/free - we need to find a less malloc/free and lock/mutex intensive way to determine if the DN RDN attribute has DN syntax

[389-ds-bot]

Comment from lkrispen (@elkris) at 2012-11-12 18:53:02

The locking problem should be resolved by ticket 504.505.
The malloc/free could be avoided by replacing slapi_attr_init/done by a call to attrsyntax_get_by_name() since the attr is not needed. It could be done in a function is_dn_syntax(attrtypename).

[389-ds-bot]

Comment from lkrispen (@elkris) at 2012-11-16 19:38:14

attachment
0001-Fix-for-ticket-510.patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2012-11-17 00:28:05

When you add an new slapi-plugin api, could you add the description, as well in slapi-plugin.h? Something like this?

/**
 * Adds a value to an attribute.
 *
 * \param a The attribute that will contain the values.
 * \param v Value to be added to the attribute.
 * \return Always returns 0.
 * \see slapi_attr_first_value()
 * \see slapi_attr_next_value()
 * \see slapi_attr_get_numvalues()
 * \see slapi_attr_value_cmp()
 * \see slapi_attr_value_find()
 */

[389-ds-bot]

Comment from lkrispen (@elkris) at 2017-02-11 23:08:18

Metadata Update from @elkris:

• Issue assigned to elkris
• Issue set to the milestone: 1.3.0