Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when lmdb import is aborted #5846

Closed
progier389 opened this issue Jul 19, 2023 · 2 comments · Fixed by #5881
Closed

Crash when lmdb import is aborted #5846

progier389 opened this issue Jul 19, 2023 · 2 comments · Fixed by #5881
Assignees
@progier389
Labels
bug Something isn't working lmdb LMDB related
Milestone
2.3

Comments

@progier389
Copy link
Contributor

Issue Description
Crash occurs when lmdb import is aborted (a typical case if is the db size is too small)
Crash is caused by a double free of the writer queue:
dbmdb_import_q_flush walk the queue to free each element but the callback free_writer_queue_item also do it.
(free_writer_queue_item should only free a single element)

Package Version and Platform:

  • Platform: Fedora, RHEL
  • Package and version: 389-ds-base-2.4.3

Steps to Reproduce
Steps to reproduce the behavior:

  1. Install an instance with lmdb (keeping default database size)
  2. Generate an ldif file with 10 M entries
  3. Import it
  4. See error (process crashed)

Expected results
Import should fail "cleanly"
@progier389 progier389 added bug Something isn't working lmdb LMDB related needs triage The issue will be triaged during scrum labels Jul 19, 2023
@progier389 progier389 added this to the 2.1.0 milestone Jul 19, 2023
@progier389 progier389 mentioned this issue Aug 3, 2023
Merged
@progier389 progier389 linked a pull request Aug 3, 2023 that will close this issue
Issue i5846 - Crash when lmdb import is aborted #5881
Merged
@progier389 progier389 self-assigned this Aug 3, 2023
@progier389 progier389 removed the needs triage The issue will be triaged during scrum label Aug 3, 2023
@progier389
Copy link
Contributor Author

BZ 2229999

@progier389 progier389 modified the milestones: 2.1.0, 2.4 Aug 8, 2023
@progier389 progier389 modified the milestones: 2.4, 2.3 Aug 11, 2023
@progier389
Copy link
Contributor Author

e84564f..3dfe80f main -> main
2490f3e..913ae18 389-ds-base-2.3 -> 389-ds-base-2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@progier389 progier389

Labels
bug Something isn't working lmdb LMDB related
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Issue i5846 - Crash when lmdb import is aborted progier389/389-ds-base
1 participant
@progier389