Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server should return unavailableCriticalExtension when processing a badly formed critical control #600

Closed
389-ds-bot opened this issue Sep 12, 2020 · 8 comments
Labels
closed: fixed Migration flag - Issue
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/600


According to http://www.ietf.org/rfc/rfc4511.txt, the server should return unavailableCriticalExtension when receiving a badly formed critical control (null length or/and null value). Currently the return value is always protocol error whatever the critical flag is true/fals

@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 12, 2020
@389-ds-bot 389-ds-bot added this to the 1.3.1 milestone Sep 12, 2020
@389-ds-bot
Copy link
Author

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2013-03-13 20:19:27

attachment
Makefile

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2013-03-22 15:06:51

'''Git merge+push''' (note I used new_branch_name to work on ticket600)

git merge new_branch_name
Updating 41d95f8..e84c63f
Fast-forward
ldap/servers/plugins/acl/acleffectiverights.c | 29 ++++++++++++++++++-----
ldap/servers/plugins/chainingdb/cb_utils.c | 15 +++++++++---
ldap/servers/plugins/deref/deref.c | 11 +++++++++
ldap/servers/slapd/back-ldbm/ldbm_search.c | 101 ++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------
ldap/servers/slapd/opshared.c | 12 +++++++---
ldap/servers/slapd/proxyauth.c | 13 +++++++---
6 files changed, 135 insertions(+), 46 deletions(-)

git push origin master
Counting objects: 31, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (16/16), done.
Writing objects: 100% (16/16), 3.18 KiB, done.
Total 16 (delta 13), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
41d95f8..e84c63f master -> master

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2013-03-22 15:46:53

commit e84c63f
Author: Thierry bordaz (tbordaz) tbordaz@redhat.com
Date: Tue Mar 12 10:41:14 2013 +0100

@389-ds-bot
Copy link
Author

Comment from nkinder (@nkinder) at 2013-04-02 03:18:23

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=947243

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2014-02-05 19:27:55

attachment
search_critical_ctl.c

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2014-02-05 19:28:08

attachment
search_critical_ctl

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2017-02-11 22:58:06

Metadata Update from @tbordaz:

  • Issue assigned to tbordaz
  • Issue set to the milestone: 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant