change slapi_entry_attr_get_bool to handle "on"/"off" values, support default value

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/47608

• Created at 2013-11-23 01:53:50 by rmeggins (@richm)
• Closed as Fixed
• Assigned to nhosoi (@nhosoi)

---

1. slapi_entry_attr_get_bool only handles "true"/"false" and "yes"/"no" - should be extended to handle "on"/"off"

2. slapi_entry_attr_get_bool should return a given default value when the attribute is not present - right now it returns 0 (false) if attribute is not present

PRBool slapi_entry_attr_get_bool_ext(const Slapi_Entry *e, const char *type, PRBool default);

[389-ds-bot]

Comment from nkinder (@nkinder) at 2013-11-23 02:34:20

What about handling "0" and "1"?

[389-ds-bot]

Comment from rmeggins (@richm) at 2013-11-23 02:42:53

Replying to [comment:1 nkinder]:

What about handling "0" and "1"?

ack

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-02-11 08:13:27

1. slapi_entry_attr_get_bool only handles "true"/"false" and "yes"/"no" - should be extended to handle "on"/"off"

slapi_entry_attr_get_bool already supports "on"/"off" and 0/non-zero.

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-02-11 08:26:45

Description: Adding an API slapi_entry_attr_get_bool_ext, which is an
extension of slapi_entry_attr_get_bool. The difference is slapi_
entry_attr_get_bool_ext returns the given default value if the type
is not found in the entry.

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-02-11 08:27:37

git patch file (master)
0001-Ticket-47608-change-slapi_entry_attr_get_bool-to-han.patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-02-12 00:36:04

Reviewed by Rich (Thank you!!)

Pushed to master:
59941ea..57af562 master -> master
commit 57af562

[389-ds-bot]

Comment from nkinder (@nkinder) at 2017-02-11 23:08:23

Metadata Update from @nkinder:

• Issue assigned to nhosoi
• Issue set to the milestone: 1.3.3 - 1/14 (January)