Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?] NCCH files do not require a .data section #142

Closed
kynex7510 opened this issue Sep 22, 2023 · 2 comments
Closed

[Bug?] NCCH files do not require a .data section #142

kynex7510 opened this issue Sep 22, 2023 · 2 comments

Comments

@kynex7510
Copy link

kynex7510 commented Sep 22, 2023

If we try to build 3ds_pdn without the workaround for generating the .data section, makerom fails with the following error:

[CODE ERROR] Failed to retrieve data sections from ELF
[NCCH ERROR] Failed to build ExeFs code
[NCCH ERROR] NCCH Build Process Failed
[RESULT] Failed to build NCCH (ret = -15)

This does not reflect HOS behaviour, which doesn't care about an empty .data section, and loads the sysmodule fine. (Tested on 11.17 with luma 12.0.1). The check should not be there and should be removed.

@jakcron
Copy link
Collaborator

jakcron commented Sep 23, 2023

I can probably fix this relatively easily. I'll ping you when I have some test builds :)

@jakcron
Copy link
Collaborator

jakcron commented Sep 30, 2023

Fixed as of MakeROM v0.18.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants