Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove column supertype_id of table datatype #204

Closed
clausnagel opened this issue Aug 12, 2023 · 2 comments
Closed

Remove column supertype_id of table datatype #204

clausnagel opened this issue Aug 12, 2023 · 2 comments
Assignees
Labels

Comments

@clausnagel
Copy link
Member

It is null for all datatypes currently. What was the purpose of this column?

@clausnagel clausnagel added the v5 label Aug 12, 2023
@thomashkolbe
Copy link
Member

I think we have introduced this to have the possibility to represent subclassing for data types. We currently might not have data types in CityGML 3.0 that are derived from other data types, but this could happen in ADEs.

@clausnagel
Copy link
Member Author

Ok, in this case the foreign key constraint on supertype_id is incorrect:

CONSTRAINT datatype_supertype_fk FOREIGN KEY (supertype_id)
  REFERENCES citydb.objectclass (id) MATCH SIMPLE
  ON UPDATE CASCADE
  ON DELETE NO ACTION

The foreign key is currently defined to reference objectclass but shall rather reference datatype itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants