importer for surfaces with inner rings creates invalid POLYHEDRALSURFACE

[hugoledoux]

With the importer v5.3.0, if I import this file (https://gist.github.com/hugoledoux/c982e49294d92390ab491f6751a0d228) (which is a simple cube with a genus=1, the top and bottom surfaces have inner rings, see below), then the POLYHEDRALSURFACE is not valid. While the geometry is valid and the cityjson file too (so not an issue here).

Each surface stored in surface_geometry is fine it seems, but the solid_geometry is not. I get that:

SRID=7415;POLYHEDRALSURFACE Z (((0.0 0.0 0.0, 0.0 1.0 0.0, 1.0 1.0 0.0, 1.0 0.0 0.0, 0.0 0.0 0.0)), ((0.2 0.2 0.0, 0.7000000000000001 0.2 0.0, 0.5 0.7000000000000001 0.0, 0.2 0.2 0.0)), ((0.0 0.0 1.0, 1.0 0.0 1.0, 1.0 1.0 1.0, 0.0 1.0 1.0, 0.0 0.0 1.0)), ((0.2 0.2 1.0, 0.5 0.7000000000000001 1.0, 0.7000000000000001 0.2 1.0, 0.2 0.2 1.0)), ((0.0 0.0 0.0, 1.0 0.0 0.0, 1.0 0.0 1.0, 0.0 0.0 1.0, 0.0 0.0 0.0)), ((1.0 0.0 0.0, 1.0 1.0 0.0, 1.0 1.0 1.0, 1.0 0.0 1.0, 1.0 0.0 0.0)), ((1.0 1.0 0.0, 0.0 1.0 0.0, 0.0 1.0 1.0, 1.0 1.0 1.0, 1.0 1.0 0.0)), ((0.0 1.0 0.0, 0.0 0.0 0.0, 0.0 0.0 1.0, 0.0 1.0 1.0, 0.0 1.0 0.0)), ((0.5 0.7000000000000001 0.0, 0.7000000000000001 0.2 0.0, 0.7000000000000001 0.2 1.0, 0.5 0.7000000000000001 1.0, 0.5 0.7000000000000001 0.0), (0.2 0.2 0.0, 0.5 0.7000000000000001 0.0, 0.5 0.7000000000000001 1.0, 0.2 0.2 1.0, 0.2 0.2 0.0), (0.7000000000000001 0.2 0.0, 0.2 0.2 0.0, 0.2 0.2 1.0, 0.7000000000000001 0.2 1.0, 0.7000000000000001 0.2 0.0)))

Notice that the 3 "internal surfaces" of the "hole" are stored in one surface, with one outer ring and 2 inner rings.

[yaozhihang]

thanks @hugoledoux. I can reproduce the problem. It seems like a bug in the code. We'll fix it asap

importer-exporter/impexp-core/src/main/java/org/citydb/core/database/adapter/postgis/GeometryConverterAdapter.java

Line 558 in 38eb584

private String convertPolygonCollectionToEWKT(GeometryObject geomObj, StringBuilder ewkt) {

[clausnagel]

Fixed with #284. The fix will be contained in the next release. Build the tool from source if you need a fixed version before the next release.