Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better boolean selection operators #371

Closed
dkoes opened this issue May 24, 2018 · 7 comments · Fixed by #467
Closed

better boolean selection operators #371

dkoes opened this issue May 24, 2018 · 7 comments · Fixed by #467

Comments

@dkoes
Copy link
Contributor

dkoes commented May 24, 2018

within doesn't work inside of and/or. Should change these to get the set of atoms selected rather than calling atomIsSelected on each atom.

@bistaastha
Copy link
Contributor

Hi @dkoes! I want to understand 3Dmol.js better and this shows up as a good first issue. Can I look into this?

@dkoes
Copy link
Contributor Author

dkoes commented Feb 23, 2020

Sure, start by writing a test case.

@bistaastha
Copy link
Contributor

Hi @dkoes ! I tried to write a test case for atomIsSelected. However, I am not able to figure out how to define AtomSpec and AtomSelectionSpec. Is there a way to define their properties without $3Dmol.download?

@dkoes
Copy link
Contributor Author

dkoes commented Feb 24, 2020

@bistaastha
Copy link
Contributor

@dkoes Thanks! I was actually working on a QUnit test for this 🤦‍♀️ . Seems like I got that wrong.

@bistaastha
Copy link
Contributor

@dkoes Is there a way to build these tests locally?

@dkoes
Copy link
Contributor Author

dkoes commented Feb 24, 2020

npm install 3dmol.js and then configure your local webserver to read from the 3dmol.js directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants