This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Feature/overlay #14
Merged
Feature/overlay #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marijnschilling
commented
Jun 10, 2016
marijnschilling
commented
- Show an overlay when the section scrubber is being scrubbed
- Change the time for hiding the element to 2 seconds
- fix some small bugs/add some safety state checks for hiding the elements
- try to fix bug where the section scrubber doesn't go all the way to the bottom [WIP]
| @@ -2,12 +2,18 @@ import UIKit | |||
|
|
|||
| public protocol SectionScrubberDelegate { | |||
| func sectionScrubber(sectionScrubber:SectionScrubber, didRequestToSetContentViewToYPosition yPosition: CGFloat) | |||
| func sectionScrubberDidStartScrubbing(sectionScrubber: SectionScrubber) | |||
| func sectionScrubberDidStopScrubbing(sectionScrubber: SectionScrubber) | |||
|
When I looked at it this morning it seemed to work fine! ✌️ (Classic) So if the PR is reviewed it can be closed! |
| } | ||
|
|
||
| public extension SectionScrubberDelegate where Self: UICollectionViewController { | ||
| func sectionScrubber(sectionScrubber:SectionScrubber, didRequestToSetContentViewToYPosition yPosition: CGFloat){ | ||
| print("contentoffset of the collectionview \(yPosition)") |
| @@ -111,12 +116,12 @@ public class SectionScrubber: UIView { | |||
| self.longPressGestureRecognizer.cancelsTouchesInView = false | |||
| self.longPressGestureRecognizer.delegate = self | |||
|
|
|||
| let scrubberGestureView = UIView(frame: CGRectMake(self.containingViewFrame.width-44,0,44,self.viewHeight)) | |||
| let scrubberGestureView = UIView(frame: CGRectMake(self.containingViewFrame.width - 44, 0, 44, self.viewHeight)) | |||
There was a problem hiding this comment.
What's 44? Would you mind making a named variable for it?
|
Besides some non named hardcoded numbers, this PR is looking pretty solid. Great job @marijnschilling 👏 |
| let y = (containingViewFrame.height * percentageInContentView) + self.containingViewFrame.minY | ||
|
|
||
| if y > 508.589 && y < 509.6 { | ||
|
|
There was a problem hiding this comment.
let y = ( too much whitespace? 😂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.