Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing with Carthage with --platform iOS still installs all platform frameworks #127

Closed
rajohns08 opened this issue Sep 6, 2016 · 11 comments

Comments

@rajohns08
Copy link

No description provided.

@3lvis
Copy link
Owner

3lvis commented Sep 6, 2016

Do you have any ideas on how to fix that? I'm not sure how that works.

Also, would be nice to understand what's the problem with having it in all the platforms?

@rajohns08
Copy link
Author

rajohns08 commented Sep 6, 2016

Not sure how to fix, but the benefit of only having the iOS platform is it is quicker to download/clone using carthage. I know this works correctly for Alamofire if you'd like to reference their repo for some sort of carthage config or something.

@3lvis
Copy link
Owner

3lvis commented Sep 7, 2016

I'll have a look, thanks a lot!

@3lvis
Copy link
Owner

3lvis commented Sep 7, 2016

Look like Alamofire's works because they don't take the time to add a pre-loaded archived version of the framework. Here's one example. Meanwhile in Networking I add a precompiled zip file of the frameworks, in this way using carthage update should be much faster in Networking than in Alamofire. The downside is that Carthage doesn't know how to avoid getting all the platforms.

Missing .zip file in Alamofire

group1

Framework .zip file in Networking

group2

@rajohns08
Copy link
Author

rajohns08 commented Sep 7, 2016

Not sure if this helps, but I noticed when pointing to your swift3 branch in my Cartfile, it worked correctly (only the iOS platform was downloaded)

@3lvis
Copy link
Owner

3lvis commented Sep 7, 2016

It's because in the Swift 3 branch, I'm not adding the .zip file.

@3lvis
Copy link
Owner

3lvis commented Sep 7, 2016

screen shot 2016-09-07 at 6 19 21 am

@3lvis
Copy link
Owner

3lvis commented Sep 7, 2016

@3lvis
Copy link
Owner

3lvis commented Sep 7, 2016

You can ear more about it from it's creator in this talk:

https://youtu.be/3BqR6_SsD8o?t=18m39s

screen shot 2016-09-07 at 6 25 43 am

@3lvis
Copy link
Owner

3lvis commented Sep 7, 2016

For me using a library that has the prebuilt binaries works much faster than using another library that doesn't have them, even if that means sending all the platforms since it doesn't need to build anything, just downloads.

@3lvis
Copy link
Owner

3lvis commented Sep 7, 2016

Closing now since I don't see a way how we could solve this without removing all the benefits of Prebuilt binaries. Let me know if you find something about it.

@3lvis 3lvis closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants