Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to provide custom implementation for the Dialog. #20

Closed
wants to merge 2 commits into from
Closed

Enable users to provide custom implementation for the Dialog. #20

wants to merge 2 commits into from

Conversation

fineswap
Copy link

This is a preliminary work to provide a Factory-based class which abstracts much of under-the-hood implementation in the library. A first implementation deals with Dialogs.

This is a preliminary work to provide a Factory-based class which abstracts much of under-the-hood implementation in the library. A first implementation deals with Dialogs.
@fineswap
Copy link
Author

@vineetmobile

This is a first pull for, hopefully, more to come. The idea is to abstract most of the internal parts so that users could be able to customize the look-and-feel of pages, dialogs and other views in the library.

I tried my best not to change the API as it stands now, and I added @deprecated notices where appropriate.

@vineetmobile
Copy link
Contributor

Hi,

Thanks for pull request. We are currently looking to change architecture. So rejecting pull request. Once done, we will welcome pull request

@fineswap
Copy link
Author

@vineetmobile
Thanks for the heads up. Let's hope it will take a short time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants