Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length of proxy username and password #2

Closed
qwertydzen opened this issue Mar 25, 2015 · 6 comments
Closed

Length of proxy username and password #2

qwertydzen opened this issue Mar 25, 2015 · 6 comments
Assignees
Milestone

Comments

@qwertydzen
Copy link

Hi,

First of all. Thank you for such great software! Use it from 2007.

Could you increase a limitations for username and password till 64 chars?
32 are very small. Some proxy-services control settings of proxy by username.

Thank you very much!

@z3APA3A
Copy link
Collaborator

z3APA3A commented Mar 26, 2015 via email

@qwertydzen
Copy link
Author

Thank you for prompt reply!
Downloaded the latest version 0.8-devel

Remote config

internal 0.0.0.0
external 0.0.0.0

users lum-customer-testeduser-zone-gen-country-us-session-1:CL:123ewqwesd32

logformat "L%C - %U [%d/%o/%Y:%H:%M:%S %z] ""%T"" %E %I %O %N/%R:%r"
auth strong
allow lum-customer-testeduser-zone-gen-country-us-session-1
parent 1000 socks5 127.0.0.1 9050

log
proxy -p1111 -a

local config

internal 0.0.0.0
external 0.0.0.0

logformat "L%C - %U [%d/%o/%Y:%H:%M:%S %z] ""%T"" %E %I %O %N/%R:%r"
auth iponly 
allow *
parent 1000 http 127.0.0.1 1111 lum-customer-testeduser-zone-gen-country-us-session-1 123ewqwesd32

log
proxy -p4388 -a

So the bug in last "local config" when 3proxy get proxy username and password.

Log in a "remote config" looks like, if I use remote proxy from a local proxy.

127.0.0.1 - lum-customer-testeduser-zone-gen [26/Mar/2015:12:00:53 +0300] "GET http://www.lagado.com/proxy-test HTTP/1.1" 00005 0 0 PROXY/0.0.0.0:0

But when I connect directly to the remote-config and specify proxy credentials in a browser I got in log right answer

127.0.0.1 - lum-customer-testeduser-zone-gen-country-us-session-1 [26/Mar/2015:11:59:58 +0300] "GET http://www.lagado.com/proxy-test HTTP/1.1" 00000 4985 328 PROXY/127.0.0.1:9050

So issue in reading username and password form parent string in config.
Highly appreciate your attention and fix!

@qwertydzen
Copy link
Author

I have sent fix in pull-request

@qwertydzen
Copy link
Author

Ping?

@z3APA3A
Copy link
Collaborator

z3APA3A commented May 4, 2015

Thanks, pulled into -devel

@z3APA3A z3APA3A closed this as completed May 4, 2015
@z3APA3A
Copy link
Collaborator

z3APA3A commented May 4, 2015

P.S. I don't recommend to use usernames like this for HTTP, because username is transmitted base64-encoded in every request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants