Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to validating admission webhook to reject EnvoyConfigs that manage an already existent node-id #160

Open
roivaz opened this issue Feb 7, 2023 · 0 comments
Open

Add check to validating admission webhook to reject EnvoyConfigs that manage an already existent node-id #160

roivaz opened this issue Feb 7, 2023 · 0 comments
Assignees
@roivaz
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Requires about a day to complete the PR or the issue.

Comments

@roivaz
Copy link
Member

roivaz commented Feb 7, 2023

Add a check in the validating admission webhook for EnvoyConfig resources to avoid a new EnvoyConfig to be created for a node-id that is already being managed by an existent EnvoyConfig. This situation causes the discovery service to enter an infinite reconciliation loop as the EnvoyConfigRevisions match 2 (or more) different EnvoyConfigs.

This could also be fixed by forcing the node-id to be the same as the EnvoyConfig resource name, but this could break existing configurations.
@roivaz roivaz added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 7, 2023
@roivaz roivaz self-assigned this Feb 7, 2023
@3scale-robot 3scale-robot added needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Feb 7, 2023
@roivaz roivaz added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. label May 19, 2023
@3scale-robot 3scale-robot removed the needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. label May 19, 2023
@roivaz roivaz added needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. labels May 19, 2023
@3scale-robot 3scale-robot removed needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. labels May 19, 2023
@roivaz roivaz added the size/M Requires about a day to complete the PR or the issue. label May 19, 2023
@3scale-robot 3scale-robot removed the needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roivaz roivaz

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Requires about a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roivaz @3scale-robot