Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system-sphinx logs display the DATABASE_URL which can contain the database password #825

Closed
dlydiard opened this issue May 5, 2023 · 2 comments

Comments

@dlydiard
Copy link

dlydiard commented May 5, 2023

The system-sphinx POD logs display the declare command that sets the DATABASE_URL, which can contain the password from the system-database secret.

Example:

declare -x DATABASE_URL="postgresql://three_scale_system:my-secret-password@database.com/database"

Per docs, this format is recommended for external databases https://github.com/3scale/3scale-operator/blob/master/doc/apimanager-reference.md#system-database

Logs shouldn't display sensitive information and should be masked.

@eguzki
Copy link
Member

eguzki commented May 5, 2023

This is out of scope of the 3scale operator.

I think you should try in https://github.com/3scale/porta

BTW: Sphinx has been replaced by searchd recently #818

@eguzki eguzki closed this as completed May 5, 2023
@mayorova
Copy link
Contributor

mayorova commented May 5, 2023

@dlydiard Thanks for the report. This issue was fixed here: https://github.com/3scale/porta/pull/3208/files#diff-6a7303480cb96bfade8adf7f87da2c9c7622a03bf4378365c3c996a55fb09c85L23-L24

It will be included in the next 3scale on-premises release.
Well, actually, as @eguzki pointed out, the sphinx component will be replaced, so it will use a different image and will not have the DATABASE_URL env var anyway.

For future bug reports and feature requests please open an issue in https://issues.redhat.com/projects/THREESCALE/issues. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants