Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 3scale application apply/create is missing an option to set the redirect url #178

Closed
nmasse-itix opened this issue Jun 20, 2019 · 5 comments · Fixed by #192
Closed

Comments

@nmasse-itix
Copy link
Contributor

Current behavior

The 3scale application apply and 3scale application create commands are missing an option that is needed for end-to-end scenario using OpenID Connect: an option to set the redirect_url(s) of the application (otherwise the standard and implicit flow cannot work)

Expected behavior

3scale application apply nmasse-redhat client-id --application-key=my-client-secret --name=my-app --plan=basic --service=api --redirect_url=https://sample.url/callback --redirect_url=https://another.url/callback
@eguzki
Copy link
Member

eguzki commented Jul 1, 2019

@nmasse-itix Should the toolbox validate those URL(s) for valid URL format?

@eguzki
Copy link
Member

eguzki commented Jul 1, 2019

@nmasse-itix More than one redirect_url is allowed? I do not see in 3scale API Docs how to add more redirect urls

@nmasse-itix
Copy link
Contributor Author

@eguzki Multiple redirect URLs are allowed in RH-SSO but not in 3scale. So only one redirect URL. 👍

@nmasse-itix
Copy link
Contributor Author

@nmasse-itix Should the toolbox validate those URL(s) for valid URL format?

If we want to validate the URL, we have to be very cautious not to be too restrictive. Mobile apps for examples can use other schemes than http(s) for their redirect url.

Given that we don't use this value internally for the toolbox but instead just pass it as-is to the system, I would not apply a double validation here. what do you think ?

@eguzki
Copy link
Member

eguzki commented Jul 1, 2019

Fair enough, toolbox will pass as-is 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants