This repository has been archived by the owner on Sep 27, 2018. It is now read-only.
Include the app_key in report keys #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we do not include the app_key in the report key, the flusher will not be able to know which app keys it needs to renew the TTL for. We were including other credentials already like app_id, user_key, access_token, etc. but we forgot about app_key.
|
Failing test before the fix possible? |
|
I added a test that not only checks that app_key is included in a report key, but also checks that all the other possible credentials (access_token, user_key, etc.) are. |
|
Travis build here: https://travis-ci.org/3scale/apicast-xc/builds/208170144 |
unleashed
approved these changes
Mar 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
If we do not include the app_key in the report key, the flusher will not be able to know which app keys it needs to renew the TTL for.
We were including other credentials already like app_id, user_key, access_token, etc. but we forgot about app_key.