Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where in Swift 4.1 the
didSet
method ofdata
method was called continuously if any of the code the redraw calls mutates anything in the array of data items, see swift bug report here.This is fairly simple to fix by having the public
data
property being a calculated var which uses an internal private equivalent used by the methods in CollectionViewController.It's possible we will be able to undo this change in a later version of swift.