Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cell size iphone x #7

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Fix/cell size iphone x #7

merged 2 commits into from
Sep 27, 2018

Conversation

simonmitchell
Copy link
Contributor

Due to the iPhone X having a width of 375 pts, when calculating available width with zero insets or interim spacing and columns == 2 the collection view would be rendered as 1 column due to the width of the device being odd. This PR makes sure the width is always floored to avoid this!

@simonmitchell simonmitchell changed the base branch from master to develop June 25, 2018 21:48
@simonmitchell simonmitchell merged commit b608751 into develop Sep 27, 2018
@simonmitchell simonmitchell deleted the fix/cell_size_iphone_x branch September 27, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants