Fixes cell separators on iPad #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laying on iPad... turns out on iPad cell separators are 1pt high rather than hairline width (1 pixel high) which mean that this was only affecting iPad. The brackets make sure our boolean logic is applied in the way we expected: if !shouldDisplaySeparators && is1PixelOrPointHigh rather than: if (!shouldDisplaySeparators && is1PixelHigh) || is1PointHight
|
|
MattCheetham
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps view height check in brackets to fix cell separators never displaying
on iPad...
turns out on iPad cell separators are 1pt high rather than hairline width
(1 pixel high) which mean that this was only affecting iPad. The brackets
make sure our boolean logic is applied in the way we expected:
if !shouldDisplaySeparators && is1PixelOrPointHigh
rather than:
if (!shouldDisplaySeparators && is1PixelHigh) || is1PointHight