Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash accessing IndexPath's section #75

Merged
merged 1 commit into from Feb 21, 2022

Conversation

simonmitchell
Copy link
Contributor

Description

Fixes crash caused when we are sent an IndexPath with 0 elements in it's indexes array (occasionally when VoiceOver enabled). See: https://developer.apple.com/forums/thread/663787

Motivation and Context

Fixes a crash in (potentially) all of our apps when VoiceOver enabled

How Has This Been Tested?

Tested locally in ARC Emergency

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

IndexPath with 0 elements in it's `indexes` array when VoiceOver enabled
@simonmitchell simonmitchell changed the base branch from develop to release/v2.0.0 February 21, 2022 16:29
@simonmitchell simonmitchell merged commit 665d8b0 into release/v2.0.0 Feb 21, 2022
@BenShutt BenShutt deleted the fix/section-indexpath-crash branch August 25, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants