New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube Short URL / List URL support #9
Conversation
url validation added, url regex added, generateURL modified, data id added, data urlQuery added, setUrlInformation created
@parsher, Thank you for your PR. Maybe we should be more declarative? I do not think it's good idea to introduce Or should I do it itself? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhance regExp
to support short URL.
Try this. |
Remove watches, data properties. Change regexes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed some regexes, and move data properties to computed. How about this?
Why do we need the |
The list of all URL formats of YouTube. |
ASAP I have free time I am going to support 90% of the available YouTube URL's. Also I'am going to introduce a |
@andrewvasilchuk Yes, we don't need the |
Closed via c22b455. It's only supported in |
Hello. Thank you for creating this component.
I added some features. Would you merge this?
If you don't like my code styles, please modify anything that you want.
Added features:
History:
URL
validation addedURL
regex addedgenerateURL
modifiedid
addedurlQuery
addedsetUrlInformation
created