Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alwaysShowTitle property #12

Merged
merged 3 commits into from Dec 28, 2021
Merged

Add alwaysShowTitle property #12

merged 3 commits into from Dec 28, 2021

Conversation

Horoshev36
Copy link
Contributor

@Horoshev36 Horoshev36 commented Dec 27, 2021

Status

READY

Breaking Changes

NO

Description

Add alwaysShowTitle property

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ“ Documentation

@divshekhar
Copy link
Member

Hey @drakonov, the flutter analysis check has failed because of unused import. It is requested to run flutter analyze --no-pub and remove the issues. Thank you!

@Horoshev36
Copy link
Contributor Author

Thank you for your note, now I corrected and went through flutter analyze --no-pub, now it does not give errors

@divshekhar
Copy link
Member

There are some automated checks:

  1. Format - flutter format --set-exit-if-changed lib
  2. Analyze - flutter analyze --no-pub
    Please format and analyze, to pass the checks.

@Horoshev36
Copy link
Contributor Author

I don't understand why it doesn't pass flutter format --set-exit-if-changed lib.

@Horoshev36
Copy link
Contributor Author

Just drops the error and that's it.

@divshekhar
Copy link
Member

The format check failed because the unused import was removed but not the whole line, thus creating a formatting issue.

@Horoshev36
Copy link
Contributor Author

That's how it is, now it's more or less clear.

@Horoshev36
Copy link
Contributor Author

All checks have passed

@4-alok 4-alok merged commit 41c3fd1 into DevsOnFlutter:main Dec 28, 2021
Copy link
Member

@4-alok 4-alok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution; it will be published on pub.dev soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants