Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Improvements to truffle/bin/capture-test-blocks.sh script #3

Open
aldoborrero opened this issue Jan 30, 2020 · 0 comments
Open

Improvements to truffle/bin/capture-test-blocks.sh script #3

aldoborrero opened this issue Jan 30, 2020 · 0 comments
Labels
Priority: Low Size: Atomic An atomic piece of work with a single associated PR Status: Available Type: Enhancement Improvements or additions Type: Good first issue Good for newcomers

Comments

@aldoborrero
Copy link
Member

truffle/bin/capture-test-blocks.sh is the script in charge of generating a test blockchain to execute tests. The script in its current state is very naive and simplistic in how it handle error failures.

If for example we want to generate blocks and somehow the testing suite fails, a dangling docker besu image is kept running without being terminated.

A good approach could be using trap signals like this good article explains. So the script is allowed to handle the error and finish its state cleanly.

@brianmcgee brianmcgee added the Size: Atomic An atomic piece of work with a single associated PR label Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Low Size: Atomic An atomic piece of work with a single associated PR Status: Available Type: Enhancement Improvements or additions Type: Good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants