Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added value alias for @BeanProperty #123

Merged
merged 1 commit into from Dec 20, 2018
Merged

Conversation

arjanvlek
Copy link
Contributor

@arjanvlek arjanvlek commented Dec 13, 2018

@BeanProperty could only be used with a name property. Adding a
value alias allows this annotation to be used without any prefix and
just the name of the property.

Also corrected all warnings about javadoc (missing returns).

Fixes #122

@arjanvlek arjanvlek changed the title Added value alias for @BeanCollection Added value alias for @Property Dec 13, 2018
@BeanProperty could only be used with a `name` property. Adding a
`value` alias allows this annotation to be used without any prefix and
just the name of the property.

Also corrected all warnings about javadoc (missing returns).

Fixes #122
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #123 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
+ Coverage     93.76%   93.78%   +0.01%     
- Complexity      847      849       +2     
============================================
  Files            87       87              
  Lines          1781     1785       +4     
  Branches        173      174       +1     
============================================
+ Hits           1670     1674       +4     
  Misses           67       67              
  Partials         44       44
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/beanmapper/BeanMapper.java 100% <ø> (ø) 14 <0> (ø) ⬇️
...er/core/collections/AbstractCollectionHandler.java 92.3% <ø> (ø) 12 <0> (ø) ⬇️
...c/main/java/io/beanmapper/core/BeanMatchStore.java 96.87% <100%> (+0.1%) 38 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c58168...5750e03. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #123 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
+ Coverage     93.76%   93.78%   +0.01%     
- Complexity      847      849       +2     
============================================
  Files            87       87              
  Lines          1781     1785       +4     
  Branches        173      174       +1     
============================================
+ Hits           1670     1674       +4     
  Misses           67       67              
  Partials         44       44
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/beanmapper/BeanMapper.java 100% <ø> (ø) 14 <0> (ø) ⬇️
...er/core/collections/AbstractCollectionHandler.java 92.3% <ø> (ø) 12 <0> (ø) ⬇️
...c/main/java/io/beanmapper/core/BeanMatchStore.java 96.87% <100%> (+0.1%) 38 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c58168...5750e03. Read the comment docs.

@arjanvlek arjanvlek changed the title Added value alias for @Property Added value alias for @BeanProperty Dec 13, 2018
@arjanvlek arjanvlek merged commit 6c2e500 into master Dec 20, 2018
@arjanvlek arjanvlek deleted the beanproperty-value-alias branch December 20, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add value alias for @BeanProperty
1 participant