You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like a nice package. I was reviewing the code, I noticed you allow prefixing the table names. The migrations only use the prefix on the up() method. When calling down via a rollback, you could end up dropping a different table. Kind of a critical issue.
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
Schema::create(config('workflows.db_prefix').'workflows', function (Blueprint $table) {
$table->id();
$table->string('name');
$table->timestamps();
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
Schema::dropIfExists('workflows');
}
}
The text was updated successfully, but these errors were encountered:
Looks like a nice package. I was reviewing the code, I noticed you allow prefixing the table names. The migrations only use the prefix on the up() method. When calling down via a rollback, you could end up dropping a different table. Kind of a critical issue.
The text was updated successfully, but these errors were encountered: