Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack: When unthreading messages, quote previous message #343

Closed
patcon opened this issue Jan 18, 2018 · 5 comments
Closed

Slack: When unthreading messages, quote previous message #343

patcon opened this issue Jan 18, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@patcon
Copy link
Contributor

patcon commented Jan 18, 2018

Currently, when two Slack teams are connected, threaded message responses are unthreaded into regular messages. This results in lost context.

I wonder whether we could use quotes in messages to give these messages more context. I'm unclear if this would be simple to do, or if it would require extra calls to slack API.

This quote could be either the original message of thread, or the one just prior. (The original message might make more sense, and would be possible to CTRL+F through logs and find all the responses.)

This would be particularly useful for responses to older messagemiis, for which unthreading is quite confusing.

Currently, mitigating this issue is only possible with social conventions that are hard to enforce: for example, 1) people avoiding threading, or 2) being explicit about which message you're responding to. That isn't ideal :)

@42wim 42wim added the enhancement New feature or request label Jan 20, 2018
@42wim
Copy link
Owner

42wim commented Jan 20, 2018

Looked into it, would need lots of changes, extra state keeping.
This is nothing that can/will be added short-term

@patcon
Copy link
Contributor Author

patcon commented Jan 21, 2018

Thanks for investigating :)

Just to bump a half-formed idea in here -- what if:

  1. there was a flag that would cause slack messages to do lookups in the ring cache for original messages on thread replies
    • successful lookup would cause slack messages to be prefixed with

      > The first ten words of the original thread message so...
      
      The unthreaded message that currently gets relayed on its own.
      
  2. as is currently possible, ring cache buffer could be bumped with a protocol-level config for Buffer=<big number> in the toml

Would this be a possible path forward, when the time comes. The slight but of context would very helpfully hint the reader to the originated message, and they could use built-in search of the backscrool if they don't recall the rest :)

@42wim
Copy link
Owner

42wim commented Feb 3, 2018

Well, the ring cache is only used by the api bridge.
The other cache doesn't keep messages text, only IDs.
Extending it to keep messages could be possible though.

@42wim
Copy link
Owner

42wim commented Feb 17, 2019

Has been fixed by supporting threading in slack I guess?

@42wim 42wim closed this as completed Feb 17, 2019
@patcon
Copy link
Contributor Author

patcon commented Feb 18, 2019

This was to avoid confusion when cache is lost and unthreads, but fine to close, since I'm not working on it right now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants