Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID3 2.0 Release #27

Closed
6 of 8 tasks
43081j opened this issue May 22, 2015 · 5 comments · Fixed by #42
Closed
6 of 8 tasks

ID3 2.0 Release #27

43081j opened this issue May 22, 2015 · 5 comments · Fixed by #42

Comments

@43081j
Copy link
Owner

43081j commented May 22, 2015

I have been gone a long time and have had very little time to maintain this repo (I still do lack time, in fact). However, I am going to give 2.0 a go.

This won't be a release of any new functionality but rather a major cleanup/refactor and improvement of build process, along with any possible bug fixes brought up since I was last around.

TODO

  • Add gulp along with necessary tasks
  • Use browserify instead of manually trying commonjs/amd/globals
  • Move dependencies to NPM instead (readerjs)
  • Move dataview-extras to a separate class rather than extending the native DataView
  • Fix any lint issues
  • Fix major bugs

Notes

The current branch being used for this is feature/browserify-cleanup, not so appropriately named but it'll do for now.

The browserify output needs testing. I have tried it quickly with an mp3 in my browser and it worked fine.

Please do help if you can, this is not such a simple task and I do not have the capacity to do it alone in an acceptable time frame

J

@MaffooBristol
Copy link

Hello! What's the current situation with this release?

@43081j
Copy link
Owner Author

43081j commented Jul 19, 2015

We have some issues with the decodeURIComponent calls, I haven't yet had time to go through it.

Also, the fix for #6 seems too much of a workaround to me, rather than a solution. I am not entirely sure why it happens as there seem to be multiple cases. Suppressing it doesn't really tell us why, does it?

@vheuken
Copy link

vheuken commented Jul 31, 2015

Any progress on this release? Getting #6 fixed is pretty crucial.

@r3wt
Copy link

r3wt commented Sep 15, 2015

convert readAsBinaryString -> readAsArrayBuffer so we can support IE?

@sc1305
Copy link

sc1305 commented Oct 22, 2015

Is only the dist/id3.min.js updated with new lib files? Can you please checkin updated id3.js also.

@43081j 43081j mentioned this issue Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants