Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard filter #82

Open
rena-jp opened this issue Aug 8, 2022 · 3 comments
Open

Leaderboard filter #82

rena-jp opened this issue Aug 8, 2022 · 3 comments

Comments

@rena-jp
Copy link
Contributor

rena-jp commented Aug 8, 2022

I have created a leaderboard filter module.
leaderboard_filter

This module can filter ranked players by name, level and club members.
I'm sorry but I could not fully test filtering by club members because none of my club members were ranked馃槕
Please someone test it.

By the way, I would like to filter by my favorite players.
To do this, I need to save and load the list of my favorite players to local storage.
I would also like to add a player to my favorite list from league, season, profile, etc.
It would be better to make this feature a common module and make it available from other modules.
Any ideas?

@R4rum
Copy link

R4rum commented Aug 8, 2022

If you made it easy to test, maybe I would have. But the new version doesn't appear to be compiled in the dist.

@rena-jp
Copy link
Contributor Author

rena-jp commented Aug 8, 2022

Thank you for advice.

Here is the test build.
https://github.com/rena-jp/hh-plus-plus/raw/leaderboard-filter/dist/hh-plus-plus.user.js

@R4rum
Copy link

R4rum commented Aug 8, 2022

It seems to work for me. The club member filter, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants