Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to use normal, nologin user as a Samba share user #4

Closed
louhisuo opened this issue Aug 14, 2021 · 2 comments
Closed

Not possible to use normal, nologin user as a Samba share user #4

louhisuo opened this issue Aug 14, 2021 · 2 comments
Assignees

Comments

@louhisuo
Copy link

To minimize attack footprint within my NAS as normal users but without shell, as nologin users (example of such user below).
pikachu:x:1009:1002:,,,:/home/pikachu:/usr/sbin/nologin

When looking into your code
-> cockpit-file-sharing/file-sharing/samba-manager/samba-manager.js
-> function add_user_options()

you define nologin users as system users and filter them out. According my limited understanding this is not correct approach. Instead of using 'nologin' as criteria, please consider other means .e.g. do filtering based on UID ranges as system users are typically having UID <1000. You may look into Linux Standard Base (LSB) reserved ranges, implementations in different Linux distros as your reference for UID ranges for system users.

@sam55silver
Copy link
Contributor

Hello, this issue has been noted and we plan to start work on this as soon as possible. Thank you for your help and you can expect an update in the near future.

@joshuaboud
Copy link
Member

fixed with #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants