Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file editing: add "file" and "coreutils" deps #44

Merged
merged 2 commits into from Jun 6, 2022

Conversation

fmsy
Copy link
Contributor

@fmsy fmsy commented Apr 2, 2022

installing the cockpit-navigator package on a minimal system does not install "file"
when trying to open a text file for editing an uncought promise is being caused here:

var proc_output = await cockpit.spawn(["file", "--mime-type", this.path_str()], {superuser: "try"});

a quick search for cockpit.spawn shows that "mkdir", "rmdir" ... are spawned as well which are provided by "coreutils".

installing the cockpit-navigator package on a minimal system does not install "file" 
when trying to open a text file for editing an uncought promise is being caused by:
https://github.com/45Drives/cockpit-navigator/blob/main/navigator/components/NavFile.js#L92
fmsy referenced this pull request in 45Drives/scripts Jun 6, 2022
@joshuaboud
Copy link
Member

Great work on your x2d function. Linking that comment here for reference. 45Drives/scripts@700d122#commitcomment-75423099

@joshuaboud joshuaboud merged commit 52bdef6 into 45Drives:main Jun 6, 2022
@joshuaboud
Copy link
Member

Packaged in 0.5.8-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants