Catch exceptions in freestyle-config #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the return type of all the methods on `Config` to `Either[ConfigException, A]` (aliased as `Config.Result`).
peterneyens
force-pushed
the
peter-config-catch
branch
from
73ae9eb
to
f8340fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 72.75% 74.52% +1.76%
==========================================
Files 36 36
Lines 312 314 +2
==========================================
+ Hits 227 234 +7
+ Misses 85 80 -5 |
raulraja
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the return type of all the methods on
ConfigtoEither[ConfigException, A](aliased asConfig.Result) and catchesConfigExceptions using Cats'Either.catchOnly.Fixes #260.