Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Implements the basic functionality in a basic way #2

Merged
merged 2 commits into from Jan 9, 2017

Conversation

fedefernandez
Copy link
Contributor

This PR adds some basic functionality to the plugin.

It includes two tasks:

  • showDependencyUpdates: Prints a table with all possible dependency updates
  • updateDependencyIssues: Creates and updates issues for all dependency updates

I've created a sample repo to test the functionality, you just need to publish locally this plugin and test it with the project sbt-dependencies-tests

Bear in mind that it's a very basic implementation, there are a lot of pending tasks like using another monad for the execution, microsite, tests, ...

Please @raulraja @juanpedromoreno could you review? Thanks

Copy link

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! This is going to be very useful!

"org.scalactic" %% "scalactic" % "3.0.0",
"org.scalatest" %% "scalatest" % versions("scalatest") % "test",
"org.scalacheck" %% "scalacheck" % versions("scalacheck") % "test"
"org.scalactic" %% "scalactic" % "3.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of scalactic if not in use

}
case None =>
streams.value.log.info(
"Can't read the access token, please set the GitHub token with the property 'githubToken' (for ex. `sbt -DgithubToken=XXXXXX`)\n")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include the link to where to get it and the type of token the user needs in this error msg as well

object TablePrinter {

def format(table: Seq[Seq[String]]) = table match {
case Seq() => ""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nil

@fedefernandez fedefernandez merged commit b29be14 into master Jan 9, 2017
@fedefernandez fedefernandez deleted the initial-implementation branch January 9, 2017 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants