This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Upgraded macroid #27
Merged
Upgraded macroid #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| heightScreen: Int, | ||
| params: WindowManager.LayoutParams, | ||
| windowManager: WindowManager): Unit = { | ||
| def changePositionIfIsNecessary(widthScreen: Int, heightScreen: Int, params: WindowManager.LayoutParams, windowManager: WindowManager): Unit = { |
There was a problem hiding this comment.
Not sure if this format is better, this line is too long. Maybe you don't have our formatting preferences?
|
Minor comments |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
macroidandmacroid-extraversion and replaces the layouts inActionsViewandDisableViewfor macroid-ui using the newServiceContextWrapperin the new version of macroid library@fedefernandez can you please review? thanks!