Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Redesign for trait DataSource #168

Closed
diesalbla opened this issue Oct 31, 2018 · 0 comments
Closed

Small Redesign for trait DataSource #168

diesalbla opened this issue Oct 31, 2018 · 0 comments

Comments

@diesalbla
Copy link
Contributor

Consider if it would be convenient to modify the DataSource trait, by moving the F[_] parameter to the trait, and the type-class bounds into protected methods of the trait. I.e., that would be replacing the following:

trait DataSource[I, A] {
  def fetch[F[_] : ConcurrentEffect : Par](id: I): F[Option[A]]

by the following:

trait DataSource[F[_], I, A] {
  protected implicit def conc: ConcurrentEffect[F]
  protected implicit def par: Par[F] 
  def fetch(id: I): F[Option[A]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants