Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross build for Scala 2.13 #216

Closed
bijancn opened this issue Sep 18, 2019 · 3 comments
Closed

Add cross build for Scala 2.13 #216

bijancn opened this issue Sep 18, 2019 · 3 comments

Comments

@bijancn
Copy link

bijancn commented Sep 18, 2019

I might to be blind to find it but I don't see any progress or discussion towards adding Scala 2.13 (and sbt 1.3 ?) to the build. As I am currently upgrading my services, this is the first library that doesn't have a 2.13 release. The upgrade itself should not be hard to do.

That being said I would also like to see cats effect 2.0 being used. Should I put this to a separate issue?

@purrgrammer
Copy link
Contributor

I might to be blind to find it but I don't see any progress or discussion towards adding Scala 2.13 (and sbt 1.3 ?) to the build. As I am currently upgrading my services, this is the first library that doesn't have a 2.13 release. The upgrade itself should not be hard to do.

Indeed, upgrading to Scala 2.13 should be straightforward, I think we can probably support 2.11 through 2.13, although I'm fine dropping support for the 2.11 series. I'll leave this issue open to address it, happy to review/merge a PR if you have the time. If not I'll get to it at some point.

That being said I would also like to see cats effect 2.0 being used. Should I put this to a separate issue?

The latest release (1.2.0) is using cats-effect 2.0, so there is no need for another issue. Thanks for reporting!

@bijancn
Copy link
Author

bijancn commented Sep 18, 2019

Cool! When you don't have too many dependencies, keeping 2.11 support should be okay. I had to drop it in my middleware libaries as I found it too hard to find library versions that work across 11, 12 and 13. I will do dependency updates first then (also using your latest release :)) and another library upgrade and when I'm done with that and you haven't come to it, I will try to update this one.

BTW, I found https://github.com/scala/scala-collection-compat/ handy so you can use
import scala.jdk.CollectionConverters._ already on 2.12, not sure if you need it.

purrgrammer added a commit that referenced this issue Sep 19, 2019
Update to Scala 2.13, SBT 1.3 and bump some libraries (Issue #216)
@juanpedromoreno
Copy link
Contributor

This is now part of Fech, thanks @bijancn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants