Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sequential and parallel batches #113

Merged
2 commits merged into from
Mar 14, 2017
Merged

Allow sequential and parallel batches #113

2 commits merged into from
Mar 14, 2017

Conversation

peterneyens
Copy link
Contributor

I made it possible to configure if you want to execute batches to a data source sequentially or in parallel.

By default they will be parallel, so we should mention in the next release notes that people relying on the sequential execution of the batches should update their data sources to specify this sequential execution.

@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #113 into master will increase coverage by 0.62%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   76.66%   77.29%   +0.62%     
==========================================
  Files          10       10              
  Lines         240      251      +11     
  Branches        2        2              
==========================================
+ Hits          184      194      +10     
- Misses         56       57       +1
Impacted Files Coverage Δ
shared/src/main/scala/datasource.scala 66.66% <ø> (ø)
shared/src/main/scala/interpreters.scala 93.12% <100%> (-0.21%)
shared/src/main/scala/fetch.scala 81.08% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c24470...20c686e. Read the comment docs.

@ghost
Copy link

ghost commented Mar 14, 2017

👏 👏 👏 Amazing work, well done!

Don't batch `FetchMany`s without a maximum batch size
@ghost ghost merged commit ea13e50 into master Mar 14, 2017
@ghost ghost deleted the peter-parallel-batches branch March 14, 2017 14:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants