Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.0 release #114

Merged
5 commits merged into from
Mar 17, 2017
Merged

0.6.0 release #114

5 commits merged into from
Mar 17, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2017

Title says it all, had to revert #109 due to clashes with the Fetch companion's apply method. Other than that is just documentation for the new features and a changelog update.

@ghost ghost requested review from raulraja and peterneyens March 17, 2017 10:06
Copy link
Contributor

@peterneyens peterneyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the documentation 🎉

# Batching

As we have learned, Fetch performs batched requests whenever it can. It also exposes a couple knobs
for tweaking the maximum batch size and whether multiple batches are run on parallel or sequentially.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on -> in ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov-io
Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #114 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #114      +/-   ##
=========================================
- Coverage   77.29%   77.1%   -0.19%     
=========================================
  Files          10      10              
  Lines         251     249       -2     
  Branches        2       2              
=========================================
- Hits          194     192       -2     
  Misses         57      57
Impacted Files Coverage Δ
shared/src/main/scala/fetch.scala 80% <ø> (-1.09%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea13e50...b62ab83. Read the comment docs.

@ghost ghost merged commit 61bed1d into master Mar 17, 2017
@ghost ghost deleted the batch-changes-release branch March 17, 2017 12:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants