Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes dup doc files #117

Merged
merged 4 commits into from
Apr 19, 2017
Merged

Conversation

juanpedromoreno
Copy link
Contributor

@juanpedromoreno juanpedromoreno commented Apr 19, 2017

This PR removes some unneeded files and it also removes the README.md file inside the tut directory. Hence, tut will compile the file in the root folder instead.

Please, @fedefernandez could you review? Thanks!

@juanpedromoreno juanpedromoreno changed the title Removes the need to have two readme files Removes dup doc files Apr 19, 2017
@codecov-io
Copy link

codecov-io commented Apr 19, 2017

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files          10       10           
  Lines         250      250           
  Branches        2        2           
=======================================
  Hits          194      194           
  Misses         56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744d2b1...882517a. Read the comment docs.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

Minor comment added

@@ -52,8 +52,8 @@ object ProjectPlugin extends AutoPlugin {
aggregate in doc := true)

lazy val readmeSettings: Seq[Def.Setting[_]] = tutSettings ++ commonTutSettings ++ Seq(
tutSourceDirectory := baseDirectory.value,
tutTargetDirectory := baseDirectory.value.getParentFile,
tutSourceDirectory := baseDirectory.value.getParentFile,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use here (baseDirectory in LocalRootProject).value instead

tutSourceDirectory := baseDirectory.value,
tutTargetDirectory := baseDirectory.value.getParentFile,
tutSourceDirectory := baseDirectory.value.getParentFile,
tutTargetDirectory := baseDirectory.value.getParentFile / "target",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -82,6 +82,7 @@ object ProjectPlugin extends AutoPlugin {
ScalaJSBadge.apply(_),
GitHubIssuesBadge.apply(_)
),
orgSupportedScalaJSVersion := Some("0.6.15"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juanpedromoreno juanpedromoreno merged commit da440e1 into master Apr 19, 2017
@juanpedromoreno juanpedromoreno deleted the jp-removes-duplicated-readme-file branch April 19, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants