Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and reuse TestHelper #132

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Move and reuse TestHelper #132

merged 1 commit into from
Aug 21, 2017

Conversation

peterneyens
Copy link
Contributor

I moved the "Async" DataSources into TestHelper, moved TestHelper to its own file and reused TestHelper in the tests of fetch-monix and fetch-twitter.

I minimized the imports of the test files in the meanwhile.

@codecov-io
Copy link

codecov-io commented Aug 21, 2017

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files          15       15           
  Lines         321      321           
  Branches        2        2           
=======================================
  Hits          253      253           
  Misses         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8766d50...fc82532. Read the comment docs.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor, looks good to me!
giphy

@peterneyens peterneyens merged commit 8012948 into master Aug 21, 2017
@peterneyens peterneyens deleted the peter-testhelper branch August 21, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants