Update dependencies (Cats 1.0.0-MF) #137
Conversation
Use library versions from sbt-org-policies.
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 78.81% 78.09% -0.73%
==========================================
Files 15 16 +1
Lines 321 315 -6
Branches 2 2
==========================================
- Hits 253 246 -7
- Misses 68 69 +1
Continue to review full report at Codecov.
|
| @@ -1184,8 +1161,6 @@ Note that Cats' typeclass hierarchy is expressed with inheritance and methods fr | |||
| We make use of the `FromMonadError` class below, making it easer to implement `FetchMonadError[Task]` given a `MonadError[Task, Throwable]` which we can get from the _monix-cats_ projects. | |||
|
|
|||
| ```tut:silent | |||
| import monix.cats._ | |||
|
|
|||
| implicit val taskFetchMonadError: FetchMonadError[Task] = | |||
| new FetchMonadError.FromMonadError[Task] { | |||
| override def runQuery[A](q: Query[A]): Task[A] = queryToTask[A](q) | |||
There was a problem hiding this comment.
Has this method been removed here? Should this be updated?
There was a problem hiding this comment.
I removed the method from FromMonadError because it is inherited from FetchMonadError.
|
|
||
| class FetchRunner[M[_]] { | ||
| private[fetch] class FetchRunner[M[_]](private val dummy: Boolean = true) extends AnyVal { |
There was a problem hiding this comment.
I'm curious, why we need this dummy value?
There was a problem hiding this comment.
That is a trick to make FetchRunner a value class that is used in Cats as well.
There was a problem hiding this comment.
Great, thanks for the responses
|
II think if we merge this, merge master in #135 it will pass as well. |
This PR upgrades Fetch to Cats 1.0.0-MF (and monix to 3.0.0-M1, catbird to 0.18.0).
We are now also using sbt 1.0.2 (thanks to @suhasgaddam for his help here and in sbt-org-policies).