Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI build #173

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Upgrade CI build #173

merged 2 commits into from
Jan 10, 2019

Conversation

diesalbla
Copy link
Contributor

Upgrade Ruby version to 2.3.0.
Add othe JDKs
Upgrade Scala version 2.12 to 2.12.8

Upgrade Ruby version to 2.3.0.
Add othe JDKs
Upgrade Scala version 2.12 to 2.12.8
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #173   +/-   ##
======================================
  Coverage    95.2%   95.2%           
======================================
  Files           6       6           
  Lines         167     167           
  Branches        7       7           
======================================
  Hits          159     159           
  Misses          8       8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9af77c...ff6913d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #173   +/-   ##
======================================
  Coverage    95.2%   95.2%           
======================================
  Files           6       6           
  Lines         167     167           
  Branches        7       7           
======================================
  Hits          159     159           
  Misses          8       8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9af77c...db69d83. Read the comment docs.

@purrgrammer
Copy link
Contributor

It seems that for some builds sbt cannot find the Scalajs compiler version, see this build log.

Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you can add addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.26") to the plugins.sbt file, so you can use Scala 2.12.8.

@purrgrammer purrgrammer merged commit 1d046ee into master Jan 10, 2019
@purrgrammer purrgrammer deleted the upgrade_CI_build branch January 10, 2019 17:39
bijancn pushed a commit to bijancn/fetch that referenced this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants