Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Implementation #203

Merged
merged 22 commits into from
Sep 10, 2019
Merged

Conversation

AntonioMateoGomez
Copy link
Contributor

@AntonioMateoGomez AntonioMateoGomez commented Jul 8, 2019

This PR updates the Fetch microsite implementing the new Fetch design.
For this we overwrite the jekyll site generated by sbt-microsites by adding a new home layout and overwriting the css classes that the documentation section uses.

It fixes #201

Do not merge since we need to wait for the Fetch Kotlin version implementation and the main site that will serve as a link to both sites #200. @47deg/marketing should schedulle these releases.

Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SASS cache files shouldn't be checked into the CVS

project/plugins.sbt Outdated Show resolved Hide resolved
project/ProjectPlugin.scala Outdated Show resolved Hide resolved
@AntonioMateoGomez AntonioMateoGomez marked this pull request as ready for review July 11, 2019 12:25
Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SASS cache file are still around, as they have been checked into VCS. Could we make sure they are not included in this PR?

Otherwise, as we are including them into the .gitignore, we'll never get rid of them.

Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌝

* This is done to avoid Oracle JDKs to fail tests
@calvellido
Copy link
Contributor

@purrgrammer I've tried to fix the tests, since there was a change in Oracle JDK license that made it unavailable to certain machines in Travis. But after setting the jobs to run under Xenial, that hasn't fix them, could you have a look as you might have more context into it?

OpenJDK is working fine, maybe Oracle JDK testing might be dropped altogether?

Thanks!

@purrgrammer
Copy link
Contributor

OpenJDK is working fine, maybe Oracle JDK testing might be dropped altogether?

Yes, we've had issues with Oracle JDK in other builds too, we can just run the tests in OpenJDK 👍

Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@purrgrammer
Copy link
Contributor

Outstanding work, LGTM 👏

@calvellido calvellido dismissed purrgrammer’s stale review September 9, 2019 14:32

It was just a misstep in the way of checking

@AntonioMateoGomez AntonioMateoGomez merged commit 3d84d36 into master Sep 10, 2019
@calvellido calvellido deleted the paolo-201-implement-redesign branch September 10, 2019 07:53
bijancn pushed a commit to bijancn/fetch that referenced this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Fetch redesign in the actual microsite
5 participants