Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate fetching a single identity and fetching many in DataSource #53

Merged
5 commits merged into from
May 29, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 27, 2016

@raulraja please take a look. @MaureenElsberry if you could do a language pass to the edited docs would be great.

@@ -123,6 +134,23 @@ given an id, we just have to pass a `UserId` as an argument to `Fetch`.
def getUser(id: UserId): Fetch[User] = Fetch(id) // or, more explicitly: Fetch(id)(UserSource)
```


### Data sources that don't support batcihng
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batching

@raulraja
Copy link
Contributor

LGTM!

@ghost ghost merged commit b55aa01 into master May 29, 2016
@ghost ghost deleted the separate-fetchone-and-fetchmany branch May 29, 2016 15:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant